Support join with dynamic fields #4746
Open
+952
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykmr1224
force-pushed
the
dynamic-join
branch
3 times, most recently
from
de18e85 to
bd31d16
Compare
ykmr1224
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar and
yuancu
as code owners
ykmr1224
commented
Nov 7, 2025
| } | ||
|
|
||
| @Test | ||
| public void testJoinDynamicWithStaticWithoutCast1() throws IOException { |
Collaborator
Author
There was a problem hiding this comment.
Type coercion cannot solve this issue since EQUAL operator is defined as parameters=[Comparable, Comparable]. (Underlying problem is, when Equal(Object, *) is used, Calcite generate invalid code.)
I am thinking to define another definition of EQUAL operator specific for ANY type to workaround this issue.
ykmr1224
force-pushed
the
dynamic-join
branch
2 times, most recently
from
7d57d90 to
56eb6f9
Compare
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
force-pushed
the
dynamic-join
branch
from
56eb6f9 to
e2587bd
Compare
Signed-off-by: Tomoyuki Morita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for feature branch
feature/permissiveDescription
Related Issues
Permissive mode RFC: #4349
Dynamic fields RFC: #4433
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.